-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding adx #99 #128
adding adx #99 #128
Conversation
Codecov Report
@@ Coverage Diff @@
## main #128 +/- ##
==========================================
- Coverage 46.14% 45.90% -0.24%
==========================================
Files 58 60 +2
Lines 2815 2884 +69
==========================================
+ Hits 1299 1324 +25
- Misses 1504 1548 +44
Partials 12 12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add DataExplorerScanner
to the services list in cmd\azqr\scan.go
and cmd\azqr\rules.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
adding adx support
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #99
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: