Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding adx #99 #128

Merged
merged 7 commits into from
Jul 24, 2023
Merged

adding adx #99 #128

merged 7 commits into from
Jul 24, 2023

Conversation

nachoalonsoportillo
Copy link
Contributor

@nachoalonsoportillo nachoalonsoportillo commented Jul 22, 2023

Description

adding adx support

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #99

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2023

Codecov Report

Merging #128 (9cb4e4b) into main (75645ef) will decrease coverage by 0.24%.
The diff coverage is 36.23%.

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   46.14%   45.90%   -0.24%     
==========================================
  Files          58       60       +2     
  Lines        2815     2884      +69     
==========================================
+ Hits         1299     1324      +25     
- Misses       1504     1548      +44     
  Partials       12       12              
Impacted Files Coverage Δ
internal/scanners/adx/adx.go 0.00% <0.00%> (ø)
internal/scanners/adx/rules.go 86.20% <86.20%> (ø)

Copy link
Member

@cmendible cmendible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add DataExplorerScanner to the services list in cmd\azqr\scan.go and cmd\azqr\rules.go

internal/renderers/services.go Show resolved Hide resolved
@nachoalonsoportillo nachoalonsoportillo marked this pull request as ready for review July 24, 2023 08:25
Copy link
Member

@cmendible cmendible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmendible cmendible merged commit ba5d995 into Azure:main Jul 24, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Azure Data Explorer scanner
3 participants