[build] default to minimal set of checks in precheck#374
Open
zimmy87 wants to merge 23 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the cargo xtask precheck workflow to default to a faster, minimal set of checks for local development, while preserving the previous “run almost everything” behavior behind a new --full flag.
Changes:
- Change precheck defaults to run
fmt+ a newnextest_minstage for quicker feedback. - Add
--fullto restore the prior default behavior, now mapped tonextest_fullplus the broader check set. - Split nextest execution into three modes:
--nextest(CLI-driven),--nextest-min(skipping heavier packages), and--nextest-full(full suite, incl. resiliency + integration/table variants).
Comments suppressed due to low confidence (1)
xtask/src/precheck.rs:67
- The
--allstage help text says it's the default when no specific checks are selected, but the new default behavior isfmt + nextest_min(unless--fullis used). Update this doc comment to avoid misleading CLI help output.
#[clap(long)]
nextest_report: bool,
/// Run all checks (default if no specific checks are selected)
#[clap(long)]
all: bool,
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
xtask/src/precheck.rs:144
- Repo docs currently describe
cargo xtask precheckas running a comprehensive/all set of checks (e.g.xtask/README.mdand rootREADME.md), but this PR changes the default to minimal. Please update those docs (or the CLIabout/help text) so users discover--full/--alland aren’t misled about what the default precheck does.
/// Xtask to run various repo-specific checks
#[derive(Parser)]
#[clap(about = "Run various checks")]
pub struct Precheck {
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Azure/azihsm-sdk/sessions/bb356636-9698-4da3-bfec-35ddb8f1f1fb Co-authored-by: zimmy87 <5205889+zimmy87@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Azure/azihsm-sdk/sessions/3672ab7b-3c3e-4dd5-aea3-66e73988e4c5 Co-authored-by: zimmy87 <5205889+zimmy87@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change alters the default behavior of the precheck xtask to only run a minimal set of checks including:
The previous precheck behavior that runs all checks and tests with the exception of CI-only checks is still available via the new "--full" option.
On my development machine, from a clean, unbuilt repository, the new default-minimal precheck takes 3min 39.56sec to finish.
CI behavior is unchanged.