Skip to content

[build] default to minimal set of checks in precheck#374

Open
zimmy87 wants to merge 23 commits into
mainfrom
user/v-davidz/mincheck
Open

[build] default to minimal set of checks in precheck#374
zimmy87 wants to merge 23 commits into
mainfrom
user/v-davidz/mincheck

Conversation

@zimmy87
Copy link
Copy Markdown
Contributor

@zimmy87 zimmy87 commented May 7, 2026

This change alters the default behavior of the precheck xtask to only run a minimal set of checks including:

  • fmt
  • nextest_min
    • excludes the following packages:
      • azihsm_api_tests
      • azihsm_ossl_provider
      • azihsm_res_test_dev
      • azihsm_resiliency_test_helpers
      • provider-integration-tests-cli
      • provider-integration-tests-capi
      • provider-integration-tests-nginx
      • resiliency_stress
      • resiliency_macro

The previous precheck behavior that runs all checks and tests with the exception of CI-only checks is still available via the new "--full" option.

On my development machine, from a clean, unbuilt repository, the new default-minimal precheck takes 3min 39.56sec to finish.

CI behavior is unchanged.

Copilot AI review requested due to automatic review settings May 7, 2026 23:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the cargo xtask precheck workflow to default to a faster, minimal set of checks for local development, while preserving the previous “run almost everything” behavior behind a new --full flag.

Changes:

  • Change precheck defaults to run fmt + a new nextest_min stage for quicker feedback.
  • Add --full to restore the prior default behavior, now mapped to nextest_full plus the broader check set.
  • Split nextest execution into three modes: --nextest (CLI-driven), --nextest-min (skipping heavier packages), and --nextest-full (full suite, incl. resiliency + integration/table variants).
Comments suppressed due to low confidence (1)

xtask/src/precheck.rs:67

  • The --all stage help text says it's the default when no specific checks are selected, but the new default behavior is fmt + nextest_min (unless --full is used). Update this doc comment to avoid misleading CLI help output.
    #[clap(long)]
    nextest_report: bool,
    /// Run all checks (default if no specific checks are selected)
    #[clap(long)]
    all: bool,

Comment thread xtask/src/precheck.rs Outdated
Comment thread xtask/src/precheck.rs Outdated
Copilot AI review requested due to automatic review settings May 8, 2026 21:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

xtask/src/precheck.rs:144

  • Repo docs currently describe cargo xtask precheck as running a comprehensive/all set of checks (e.g. xtask/README.md and root README.md), but this PR changes the default to minimal. Please update those docs (or the CLI about/help text) so users discover --full/--all and aren’t misled about what the default precheck does.
/// Xtask to run various repo-specific checks
#[derive(Parser)]
#[clap(about = "Run various checks")]
pub struct Precheck {

Comment thread xtask/src/precheck.rs
Comment thread xtask/src/precheck.rs Outdated
Comment thread xtask/src/precheck.rs Outdated
@zimmy87 zimmy87 marked this pull request as ready for review May 11, 2026 16:59
Copilot AI review requested due to automatic review settings May 11, 2026 16:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.

Comment thread xtask/src/precheck.rs
Comment thread xtask/src/precheck.rs Outdated
Comment thread xtask/src/precheck.rs Outdated
Comment thread xtask/src/precheck.rs
Comment thread xtask/src/precheck.rs Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 11, 2026 18:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread xtask/src/precheck.rs
Comment thread xtask/src/precheck.rs Outdated
Copilot AI review requested due to automatic review settings May 11, 2026 20:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread xtask/src/precheck.rs
Comment thread xtask/src/precheck.rs
Copilot AI review requested due to automatic review settings May 11, 2026 20:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread xtask/src/precheck.rs Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 11, 2026 21:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Comment thread xtask/src/precheck.rs Outdated
Comment thread xtask/src/precheck.rs Outdated
Comment thread xtask/src/precheck.rs Outdated
@zimmy87 zimmy87 requested a review from vsonims May 11, 2026 22:41
Copilot AI review requested due to automatic review settings May 12, 2026 18:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread xtask/src/precheck.rs
Copilot AI review requested due to automatic review settings May 13, 2026 22:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants