Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JCore-Brownfield-AppAttachVM-Fix PS and Azure CLI in readme #690

Merged

Conversation

JCoreMS
Copy link
Contributor

@JCoreMS JCoreMS commented Oct 21, 2024

Add var to PS and additional Azure CLI code block.

Overview/Summary

Fix PowerShell deployment and Azure CLI deployment code as it was non-functional. Per Issue #674

This PR fixes/adds/changes/removes

  1. PowerShell code in readme for brownfield deployment for App Attach VM revised.
  2. Azure CLI code in readme for brownfield deployment for App Attach VM revised.

Breaking Changes

  1. N/A

Testing Evidence

Deployment tested successfully using either mechanisms.

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (AVD LZA Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

Add var to PS and additional Azure CLI code block.
@JCoreMS JCoreMS requested a review from a team as a code owner October 21, 2024 19:07
@danycontre danycontre merged commit d891033 into Azure:main Oct 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants