remove the setting for sample output folder #5351
Merged
+19
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the tests project's directory
ArcturusZhang
force-pushed
the
fix-sample-generation-directory
branch
from
c79c83e to
06248ca
Compare
ArcturusZhang
requested review from
ArthurMa1978,
JoshLove-msft,
hallipr,
lirenhe and
m-nash
as code owners
...stProjects/MgmtMockAndSample/samples/Generated/Samples/Sample_DeletedManagedHsmCollection.cs
Outdated
Show resolved
Hide resolved
ArthurMa1978
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5197
Description
This PR fixes the "unify samples and tests" in a way of removing the configuration of setting the output directory of samples in mgmt plane generator.
Now the sample output directory always the
tests/Generated/directory, which is unified between DPG and mgmt.Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?