Skip to content

remove the setting for sample output folder #5351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Jun 19, 2025

Fixes #5197

Description

This PR fixes the "unify samples and tests" in a way of removing the configuration of setting the output directory of samples in mgmt plane generator.
Now the sample output directory always the tests/Generated/ directory, which is unified between DPG and mgmt.

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

Sorry, something went wrong.

…the tests project's directory

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@ArcturusZhang ArcturusZhang marked this pull request as ready for review June 23, 2025 08:19

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@ArcturusZhang ArcturusZhang merged commit ff04c40 into Azure:main Jun 25, 2025
8 checks passed
@ArcturusZhang ArcturusZhang deleted the fix-sample-generation-directory branch June 25, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify samples and tests between DPG and MPG
2 participants