Skip to content

adopt the removal of stringify-with-ref library change #5348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Jun 17, 2025

Description

Adopts the changes from microsoft/typespec#7455
Supersedes #5339

it turns out we have quite a few issues around the convenientApi being true or false.

The test project FirstTest-TypeSpec has the global setting of generate-convenient-methods: false, therefore if operations do not have @convenientApi(true), they should not have convenient methods.
But in fact, quite a few such operations have convenience methods which leads to issues because TCGC would take that information correct and models/enums related will not be included.

I think we would not bother to fix that since it only happens in DPG - which will soon be superseded by the new generator.
To make everything works correctly, I just refines the typespec files so that our expectation for convenient methods would align with TCGC's

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@ArcturusZhang ArcturusZhang changed the title adopt the remove stringify-with-ref library change adopt the removal of stringify-with-ref library change Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant