fix: treat HTTP 404 on DELETE as success (idempotent delete)#834
Open
smithimage wants to merge 1 commit intoAzure:mainfrom
Open
fix: treat HTTP 404 on DELETE as success (idempotent delete)#834smithimage wants to merge 1 commit intoAzure:mainfrom
smithimage wants to merge 1 commit intoAzure:mainfrom
Conversation
When the publisher tries to delete a resource that has already been removed from APIM (e.g. a manually deleted API revision), the DELETE call returns HTTP 404. Previously, DeleteResource threw an exception on any error response including 404, causing the entire publisher pipeline to crash. This change makes DeleteResource ignore 404 responses on DELETE, treating them as successful — the resource is already gone, which is the desired end state. This follows the REST convention of idempotent deletes and is consistent with how GetContentOption already handles 404 for GET requests. The fix applies to all resource types (ApiTag, Api, Backend, Logger, Diagnostic, etc.) since they all call DeleteResource. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the publisher tries to delete a resource that has already been removed from APIM (e.g. a manually deleted API revision), the DELETE call returns HTTP 404. Previously, DeleteResource threw an exception on any error response including 404, causing the entire publisher pipeline to crash.
This change makes DeleteResource ignore 404 responses on DELETE, treating them as successful — the resource is already gone, which is the desired end state. This follows the REST convention of idempotent deletes and is consistent with how GetContentOption already handles 404 for GET requests.
The fix applies to all resource types (ApiTag, Api, Backend, Logger, Diagnostic, etc.) since they all call DeleteResource.