Solved Issue 62: Unable to delete APIM when destroying infrastructure…

… with Terraform. (#63)

* Update APIM type to use api version `2023-03-01-preview` which does not have the issue when deleting the APIM.
* Added dependency (`depends_on`) with  for `azurerm_api_management_named_value.tenant_id` for the `azurerm_api_management_api_policy.policy` which is required when deleting the APIM due to an indirect dependency with the Tenant ID value.
* Add `prevent_deletion_if_contains_resources` flag as `false` to mitigate an open bug in Terraform. or instance, the Resource Group is not deleted when a `Failure Anomalies` resource is present. Reference: hashicorp/terraform-provider-azurerm#18026

infra/modules/apim/main.tf

@@ -4,7 +4,7 @@ locals {
 }
 
 resource "azapi_resource" "apim" {
-  type      = "Microsoft.ApiManagement/service@2023-05-01-preview"
+  type      = "Microsoft.ApiManagement/service@2023-03-01-preview"
   name      = var.apim_name
   parent_id = var.resource_group_id
   location  = var.location
@@ -168,6 +168,7 @@ resource "azurerm_api_management_api_policy" "policy" {
         </on-error>
     </policies>
     XML
+    depends_on = [ azurerm_api_management_named_value.tenant_id ]
 }
 
 # https://github.com/aavetis/azure-openai-logger/blob/main/README.md

infra/providers.tf

@@ -32,6 +32,12 @@ provider "azurerm" {
     api_management {
       purge_soft_delete_on_destroy = true
     }
+    resource_group {
+      # This flag is set to mitigate an open bug in Terraform. For instance, the Resource Group is not deleted when a `Failure Anomalies` resource is present.
+      # As soon as this is fixed, we should remove this.
+      # Reference: https://github.com/hashicorp/terraform-provider-azurerm/issues/18026
+      prevent_deletion_if_contains_resources = false
+    }
   }
 }