Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "MAINT: update DarkBench dataset (#844)" #860

Closed

Conversation

romanlutz
Copy link
Contributor

This reverts commit 3da2bae.

Description

@Akash190104 suggested we update the reference to the DarkBench dataset. However, that causes the load_dataset function to fail. Backing out this change until it's fixed. FYI @paulinek13 I needed to back out since we had to do a release just now and this was a blocker. But once we make the required changes we definitely want that back in. I tried reproducing locally and it seemed to fail on the load_dataset step but a more detailed analysis might be needed.

For v0.8.1 this is already done.

Tests and Documentation

N/A

@paulinek13
Copy link
Contributor

paulinek13 commented Apr 4, 2025

Oh, that's strange. I can't seem to reproduce it locally, regardless of the Python version I use. I tested with 3.10, 3.11, 3.12, and 3.13 (I also re-installed the deps with pip install -e .[dev]). For reference, I tested it at 2c9d7fc

🤔

Edit: Well, I couldn't reproduce it since it's using the latest cached version by default 😅, and I didn't disable it 😅. When I do, I get:

Using the latest cached version of the dataset since apart/darkbench couldn't be found on the Hugging Face Hub
Found the latest cached dataset configuration 'default' at ...

I'll certainly look into why apart/darkbench cannot be found

@jsong468
Copy link
Contributor

jsong468 commented Apr 4, 2025

Oh, that's strange. I can't seem to reproduce it locally, regardless of the Python version I use. I tested with 3.10, 3.11, 3.12, and 3.13 (I also re-installed the deps with pip install -e .[dev]). For reference, I tested it at 2c9d7fc

🤔

Edit: Well, I couldn't reproduce it since it's using the latest cached version by default 😅, and I didn't disable it 😅. When I do, I get:

Using the latest cached version of the dataset since apart/darkbench couldn't be found on the Hugging Face Hub
Found the latest cached dataset configuration 'default' at ...

I'll certainly look into why apart/darkbench cannot be found

Oh, that's strange. I can't seem to reproduce it locally, regardless of the Python version I use. I tested with 3.10, 3.11, 3.12, and 3.13 (I also re-installed the deps with pip install -e .[dev]). For reference, I tested it at 2c9d7fc

🤔

Edit: Well, I couldn't reproduce it since it's using the latest cached version by default 😅, and I didn't disable it 😅. When I do, I get:

Using the latest cached version of the dataset since apart/darkbench couldn't be found on the Hugging Face Hub
Found the latest cached dataset configuration 'default' at ...

I'll certainly look into why apart/darkbench cannot be found

Seems to work for me if I use data = load_dataset("apart/darkbench", "default", split="train", data_files="darkbench.tsv")!

@romanlutz
Copy link
Contributor Author

@jsong468 is fixing this in #862 so I'll close this

@romanlutz romanlutz closed this Apr 5, 2025
@romanlutz romanlutz deleted the romanlutz/revert_bad_darkbench branch April 5, 2025 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants