FIX jupyter set as dev dependency #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most people use PyRIT with notebooks so this is included for ease of use. |
romanlutz
reviewed
Apr 9, 2025
|
@romanlutz I apparently missed a precommit hook lint fix, would you mind retriggering the action to rerun again? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #856 . This migrate the jupyter dependency to being a dev dependency, as it's not necessary to have jupyter to run the main pyrit library.
Full rationale, as well as the associated CVE that surfaced this issue, described further in #856
The problematic dependencies are found here: https://github.com/cypress-io/cypress/blob/develop/yarn.lock#L30722
Tests and Documentation
Seems like this shouldn't impact the functionality of the package and could reduce the dependency list (and attack surface) in the event that pyrit is deployed to production by a project referencing it.