-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: introduce word-level converter #847
Open
paulinek13
wants to merge
26
commits into
Azure:main
Choose a base branch
from
paulinek13:feat/add_word_level_converter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+266
−268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
863fc37
to
8d88759
Compare
… `select_word_indices`
…ation requirements
…_ratio` parameters
8d88759
to
12b79e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new base class called
WordLevelConverter
, which simplifies the creation of word-level converters by providing a reusable foundation that standardizes word selection for transformation and reduces code duplication across similar converters.The key benefit is that one only needs to implement the specific word transformation logic (
convert_word_async
) while the base class handles word selection, iteration, and final result.Word selection strategies/modes
The base class supports various word selection modes through the
select_word_indices
util function:List of refactored prompt converters
The following converters have been refactored to use the new base class:
BinaryConverter
CharSwapGenerator
EmojiConverter
LeetspeakConverter
ROT13Converter
StringJoinConverter
TextToHexConverter
UnicodeReplacementConverter
Note: I'm not sure if all the prompt converters that I've refactored should be word-level based, or if there are other converters that haven't been refactored that would benefit from this base class.
Related: #818 (comment)
Tests and Documentation
Updated docs and tests