Skip to content

Manifest header wrong comparation between two unsigned values #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KameleonSec wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Manifest header wrong comparation between two unsigned values #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/manifest/manifest_flash.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ int manifest_flash_read_header (struct manifest_flash *manifest, struct manifest
return MANIFEST_BAD_MAGIC_NUMBER;
}

if (header->sig_length > (header->length - sizeof (struct manifest_header))) {
if ((int)header->sig_length > (int)(header->length - sizeof (struct manifest_header))) {
return MANIFEST_BAD_LENGTH;
}

Expand Down