Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(designer): Update status pill spinner for only running actions #6249

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ccastrotrejo
Copy link
Contributor

@ccastrotrejo ccastrotrejo commented Dec 11, 2024

This pull request includes multiple updates to the StatusPill component in the libs/designer-ui library. The most important changes include adding and modifying status messages in the localization file, updating the StatusPill component to use Fluent UI's Tooltip and Spinner, and improving the test snapshots for the StatusIcon component.

  • Updated StatusPill component to use Fluent UI's Tooltip instead of TooltipHost and ensured the status prop is required.
  • Modified StatusIcon component to use Fluent UI's Spinner instead of the deprecated Spinner from @fluentui/react.
  • Improved test snapshots for the StatusIcon component to reflect the changes in the spinner and tooltip.

Fixes #6201

Screenshots

Old implementation

Screenshot 2024-12-11 at 11 58 20 AM
Screenshot 2024-12-11 at 11 47 49 AM

New implementation

Screenshot 2024-12-16 at 4 53 21 PM

@ccastrotrejo ccastrotrejo changed the title feat(designer): feat(designer): Update status pill spinner for only running actions Dec 11, 2024
@ccastrotrejo ccastrotrejo requested a review from Copilot December 11, 2024 20:51
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated 3 suggestions.

Files not reviewed (3)
  • Localize/lang/strings.json: Language not supported
  • libs/designer-ui/src/lib/monitoring/statuspill/test/snapshots/statusicon.spec.tsx.snap: Language not supported
  • libs/designer-ui/src/lib/monitoring/statuspill/test/statusicon.spec.tsx: Evaluated as low risk
Comments skipped due to low confidence (1)

libs/designer-ui/src/lib/utils/utils.ts:335

  • The word 'succeeeded' is misspelled. It should be 'succeeded'.
description: 'The status message to show succeeeded retries in monitoring view.. This refers to the succeeded status of a previous action.',

libs/designer-ui/src/lib/utils/utils.ts Outdated Show resolved Hide resolved
libs/designer-ui/src/lib/utils/utils.ts Outdated Show resolved Hide resolved
libs/designer-ui/src/lib/utils/utils.ts Show resolved Hide resolved
@hartra344
Copy link
Contributor

can we also desaturate the actions that haven't run yet and aren't running similar to how old designer does? I do think that provides a nice indicator that it hasn't been touched yet.

@ccastrotrejo
Copy link
Contributor Author

can we also desaturate the actions that haven't run yet and aren't running similar to how old designer does? I do think that provides a nice indicator that it hasn't been touched yet.

Yep that sounds good, that will help to notice those aren't running yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitoring view shows spinner indicating activity on actions that haven't started yet
2 participants