fix(Designer): Fixed issue with array editor dynamic data #6221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes
Currently, if a user adds an additional parameter (typed as an array) that has dynamic data, that dynamic data will not load until the user saves and reloads the workflow.
This is because when we add the additional array parameter, it decides whether or not to load a combobox based on if there are options to show. If there are no options, it shows a string editor. The dynamic data fetch is a part of the combobox editor, so they never load the dynamic data options.
This pr adds a new
isDynamicprop so that the array editor knows when to load a combobox in situations that hasn't loaded the dynamic data options.Fixes #6154