Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SolutionId and add host.json #11643

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

daviditkin
Copy link
Contributor

@daviditkin daviditkin commented Jan 8, 2025

Required items, please complete

Change(s):

  • 3.1.1.zip modified (mainTemplate.json mods)
  • mainTemplate.json changed solutionId name
  • SoltutionMetadata changed publisherId to azurehoundenterprise
  • SolutionMetadata changed publisherId to bloodhoundenterprise-azuresentinel

Reason for Change(s):

  • Customer was asked to modify solutionId to match the package being uploaded

Version Updated:

  • None

Testing Completed:

  • Could use help, but retested mainTemplate.json and it seems fine.

Checked that the validations are passing and have addressed any issues that are present:

  • testAzTemplate showed IDs Should Be Derived From ResourceIDs
    [-] IDs Should Be Derived From ResourceIDs (55 ms)
    Property: "id" must use one of the following expressions for an resourceId property:

extensionResourceId,resourceId,subscriptionResourceId,tenantResourceId,if,parameters,reference,variables,subscription,guid
Property: "id" must use one of the following expressions for an resourceId property:
extensionResourceId,resourceId,subscriptionResourceId,tenantResourceId,if,parameters,reference,variables,subscription,guid
Property: "id" must use one of the following expressions for an resourceId property:
extensionResourceId,resourceId,subscriptionResourceId,tenantResourceId,if,parameters,reference,variables,subscription,guid
Property: "id" must use one of the following expressions for an resourceId property:
extensionResourceId,resourceId,subscriptionResourceId,tenantResourceId,if,parameters,reference,variables,subscription,guid
Property: "id" must use one of the following expressions for an resourceId property:
extensionResourceId,resourceId,subscriptionResourceId,tenantResourceId,if,parameters,reference,variables,subscription,guid
Property: "id" must use one of the following expressions for an resourceId property:
extensionResourceId,resourceId,subscriptionResourceId,tenantResourceId,if,parameters,reference,variables,subscription,guid
Property: "id" must use one of the following expressions for an resourceId property:
extensionResourceId,resourceId,subscriptionResourceId,tenantResourceId,if,parameters,reference,variables,subscription,guid
Property: "id" must use one of the following expressions for an resourceId property:
extensionResourceId,resourceId,subscriptionResourceId,tenantResourceId,if,parameters,reference,variables,subscription,guid
Property: "id" must use one of the following expressions for an resourceId property:
extensionResourceId,resourceId,subscriptionResourceId,tenantResourceId,if,parameters,reference,variables,subscription,guid
Property: "id" must use one of the following expressions for an resourceId property:
extensionResourceId,resourceId,subscriptionResourceId,tenantResourceId,if,parameters,reference,variables,subscription,guid

@daviditkin daviditkin requested review from a team as code owners January 8, 2025 19:52
@v-prasadboke v-prasadboke self-assigned this Jan 9, 2025
@v-prasadboke v-prasadboke added the Connector Connector specialty review needed label Jan 9, 2025
@daviditkin
Copy link
Contributor Author

@v-prasadboke I am going to pause this merge request until we are sure about what the solutionId should be.
I'm going to convert this to a draft but I assume there will be an updated solutionId shortly.

@daviditkin daviditkin marked this pull request as draft January 9, 2025 13:00
@daviditkin daviditkin marked this pull request as ready for review January 13, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connector Connector specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants