Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtering Script exception list bug fix #11633

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Filtering Script exception list bug fix #11633

merged 2 commits into from
Jan 7, 2025

Conversation

vakohl
Copy link
Contributor

@vakohl vakohl commented Jan 7, 2025 •
edited
Loading

Required items, please complete

Change(s):

  • Reducing Time Range for Query runs from 7 days to 2 days in ASimFilteringTest.py
  • Added a continue statement to skip the parser if it is listed in the exclusion list in ASimFiltering
  • Also, include changes to fix Native Parser EventProduct and EventVendor handling issue

Reason for Change(s):

  • Issue raised

Version Updated:

  • NA

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@vakohl vakohl requested review from a team as code owners January 7, 2025 05:47
manishkumar1991
manishkumar1991 previously approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@manishkumar1991 manishkumar1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

rahul0216
rahul0216 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@rahul0216 rahul0216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@vakohl vakohl merged commit e66047d into master Jan 7, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alekhya0824 Alekhya0824 Alekhya0824 approved these changes

@v-dvedak v-dvedak v-dvedak approved these changes

@v-sabiraj v-sabiraj v-sabiraj approved these changes

@rahul0216 rahul0216 rahul0216 approved these changes

@manishkumar1991 manishkumar1991 manishkumar1991 left review comments

Assignees

@manishkumar1991 manishkumar1991

@v-atulyadav v-atulyadav

Labels
ASIM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vakohl @rahul0216 @v-sabiraj @manishkumar1991 @v-dvedak @Alekhya0824 @v-atulyadav