Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix broken Mango Sandstorm rule #11484

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

pemontto
Copy link
Contributor

@pemontto pemontto commented Nov 25, 2024

This rule was all kinds of broken

Change(s):

  • Add ActorUsername for tables where it doesn't exist
  • Fixed the mixed case of DvcHostname and ProcessId breaking entities, preferring lowercase style as per https://learn.microsoft.com/azure/sentinel/normalization-schema-process-event
  • Fixed redundant and broken ProcessID assignment outside the union. Also cast all ProcessId fields to string so the entity doesn't break.
  • Fix the non-existent UPNSuffix entity, using NTDomain instead

Reason for Change(s):

  • So the rule can deploy and work correctly

Version Updated: ✅

Testing Completed: ✅

@pemontto pemontto requested review from a team as code owners November 25, 2024 15:14
@v-prasadboke v-prasadboke self-assigned this Nov 25, 2024
@v-prasadboke v-prasadboke added the Solution Solution specialty review needed label Nov 25, 2024
@v-prasadboke
Copy link
Contributor

Please repackage the Solution using V3

@v-atulyadav v-atulyadav merged commit f217d51 into Azure:master Nov 27, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants