Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved BloodHound Enterprise Solution #11445

Merged
merged 71 commits into from
Dec 3, 2024

Conversation

daviditkin
Copy link
Contributor

Required items, please complete

Change(s):

  • DCR custom table schema changed to reflect additional information now available from BloodHound.
  • Function App now schedules a golang executable that is connector to BloodHoundEnterprise
  • New Workbooks based on additional information now available from BloodHound
  • Alert rules modified to reflect modifications to schema

Reason for Change(s):

  • New approach to integrating with BloodHoundEnterprise. New endpoints, golang connector.
  • Additional Workbooks based on new data available from BloodHoundEnterprise

Version Updated:

  • Solution updated from 3.0.0 to 3.1.0
  • Alert Rules updated from 1.0.x to 1.1.0 to reflect modification to schema

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Need Help

Note: I have run the Test-AzTemplate and it runs without error.
I can not run the kql validation scripts I keep getting dll/version issues and I need help with that test.

ghodum and others added 30 commits October 24, 2024 14:30
…not using persisted timestamp yet so it will duplicate log records. handler is now function.
…resources. Removed Parsers files, Parsers array in Solution already empty.
@daviditkin daviditkin requested a review from a team as a code owner November 22, 2024 16:23
@daviditkin
Copy link
Contributor Author

Hello @daviditkin, Please create a custom schema table named as BloodHoundLogs_CL at location https://github.com/Azure/Azure-Sentinel/tree/master/.script/tests/KqlvalidationsTests/CustomTables

Please add workbook metadata to https://github.com/Azure/Azure-Sentinel/blob/master/Workbooks/WorkbooksMetadata.json

Make sure function app zip is updated with all the libraries and functions Also do share working images of function app

Hey @v-prasadboke , thanks for you help. I still getting validation errors, but a different set this time. Any help would be appreciated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add workbook images file name in the properties

@daviditkin
Copy link
Contributor Author

@v-prasadboke Thanks for your help. The PR now passes the first set of automated tests.

If you see anything that looks like it can be improved please let me know.

I still have some questions to make sure what I've done is correct:

  1. There are a bunch of resource id errors in mainTemplate.json that I have corrected by hand before adding it to the zip file.
    I am correcting them with this kind of modification:

"workbookcontentProductId1": "[concat(take(variables('_solutionId'),50),'-','wb','-', uniqueString(concat(variables('_solutionId'),'-','Workbook','-',variables('_workbookContentId1'),'-', variables('workbookVersion1'))))]",
"_workbookcontentProductId1": "[variables('workbookcontentProductId1')]",

  1. Is sample data required for the PR. I've not added it.

@v-prasadboke
Copy link
Contributor

Hello @daviditkin, Can you share invocation logs images for the Function app

@daviditkin
Copy link
Contributor Author

Hello @daviditkin, Can you share invocation logs images for the Function app

Hey @v-prasadboke , I'm not sure where you want me to put the images. Here is a log from test runs I just did. Let me know if I should screenshots into my solution's directory or somewhere else? I'm not sure where this screenshot should be placed.

BloodHound Function App Invocation Logs

@v-atulyadav v-atulyadav merged commit 4a082e8 into Azure:master Dec 3, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connector Connector specialty review needed Parser Parser specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants