Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ThreatIntelligence] Template updates for PMDTI GA and new types Public Preview #11396

Merged
merged 13 commits into from
Nov 28, 2024

Conversation

ni-bhandari
Copy link
Contributor

@ni-bhandari ni-bhandari commented Nov 7, 2024

Required items, please complete

Change(s):

  • Updated Taxii and Upload Indicators API data connectors descriptions to reflect new TI types (STIX objects) instead of indicators.
  • Updated "Upload Indicators API" data connector name to "Upload API"

Reason for Change(s):

  • Public preview for new types

Version Updated:

  • Yes

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Need Help
  • Running the solution generator and test scripts throws runtime errors

@ni-bhandari ni-bhandari requested review from a team as code owners November 7, 2024 21:50
@v-prasadboke v-prasadboke self-assigned this Nov 8, 2024
@v-prasadboke
Copy link
Contributor

Hello @ni-bhandari
You have added data connectors in the input file of Ti Azure gov but they are not added in the PR

@ni-bhandari
Copy link
Contributor Author

Hello @ni-bhandari You have added data connectors in the input file of Ti Azure gov but they are not added in the PR

Hi @v-prasadboke, the data connectors template files are the same ones that I have updated under the "Solutions/Threat Intelligence/Data Connectors" folder. From what I understand, this is how the templates are set up to work with the gov solution, as we followed the same in this update: the template was added in: #7500 , and gov solution package updated: #10992

Pls let me know if you want me to update the templates in a different folder as well!

@ni-bhandari
Copy link
Contributor Author

Also @v-prasadboke, the changes for this PR seems to have reverted after you added the files from the other PR here. Should I push those changes again?

@v-prasadboke v-prasadboke added the Connector Connector specialty review needed label Nov 18, 2024
@ni-bhandari ni-bhandari changed the title [ThreatIntelligence] Update description texts for new TI types [ThreatIntelligence] Template updates for PMDTI GA and new types Public Preview Nov 28, 2024
@v-prasadboke v-prasadboke merged commit 2bac943 into Azure:master Nov 28, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connector Connector specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants