Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting fixes revealed during parsing #11300

Closed
wants to merge 3 commits into from
Closed

Conversation

ccmsft
Copy link
Collaborator

@ccmsft ccmsft commented Oct 18, 2024

Required items, please complete

Change(s):

  • Updated metadata for rules to adhere to convention.

Reason for Change(s):

  • Some rule metadata was incorrect

@ccmsft ccmsft requested review from a team as code owners October 18, 2024 14:58
Copy link

Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

@v-atulyadav v-atulyadav added Solution Solution specialty review needed Hunting Hunting specialty review needed labels Oct 21, 2024
@v-shukore
Copy link
Contributor

Hello @ccmsft , Thanks for raising this PR. This PR will be investigated, and we will update you about the same before 23-10-2024. Thanks...!!

@v-shukore
Copy link
Contributor

Hi @ccmsft,

Please update the version of all Hunting Queries that you have modified, as the validation checks are failing due to the version not being updated.
image

Thanks...!!

@v-shukore
Copy link
Contributor

Hi @ccmsft, please update on above comment. Thanks

@v-shukore
Copy link
Contributor

Hi @tduarte14, please update the Hunting Queries version to resolve the validation checks. After that, we can proceed with the next steps. Thanks!

@v-shukore
Copy link
Contributor

Hi @ccmsft, please update on above comment. Thanks...!!

@v-shukore
Copy link
Contributor

Hi @tduarte14, please update the Hunting Queries version to resolve the validation checks. After that, we can proceed with the next steps. Thanks!

@v-shukore
Copy link
Contributor

Hi @ccmsft,

We wanted to check on the status of PR #11300. PR is pending for more than 30 days. Please let us know if you need any assistance to review this PR. Per our standard operating procedures if no response is received in the next 7 business days, we will close this PR.

Thank you for your cooperation.

@v-shukore
Copy link
Contributor

Hi @ccmsft, please update the Hunting Queries version to resolve the validation checks. After that, we can proceed with the next steps. Thanks!

@v-shukore
Copy link
Contributor

Hi @ccmsft, please repackage the solutions using V3 tool and commit the changes.
https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V3/README.md
Thanks!!

@v-shukore
Copy link
Contributor

Hi @ccmsft, waiting for your update please do the packaging to proceed. Thanks!!

@ccmsft ccmsft closed this Dec 6, 2024
@ccmsft
Copy link
Collaborator Author

ccmsft commented Dec 6, 2024

PR is too large, will potentially just provide a parsing tool to identify issues missed in current validations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hunting Hunting specialty review needed Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants