feat: add SIG config for Ubuntu 24.04 and AzureLinux V3 EdgeZone distros#8853
Open
prakhar1200 wants to merge 5 commits into
Open
feat: add SIG config for Ubuntu 24.04 and AzureLinux V3 EdgeZone distros#8853prakhar1200 wants to merge 5 commits into
prakhar1200 wants to merge 5 commits into
Conversation
Register new EdgeZone distro keys so AgentBaker can resolve them before RP starts returning them: AKSUbuntuEdgeZoneContainerd2404(Gen2) and AKSAzureLinuxV3EdgeZone(Gen2).
prakhar1200
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
runzhen,
sulixu,
surajssd,
timmy-wright,
titilambert,
xuexu6666 and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Registers new EdgeZone distro identifiers in AgentBaker and wires them to SIG image configuration so upcoming RP-returned distro keys can be resolved to actual SIG images (avoiding image-lookup failures during provisioning).
Changes:
- Added new distro constants for Ubuntu 24.04 EdgeZone (gen1/gen2) and AzureLinux V3 EdgeZone (gen1/gen2), and included them in the “available on VHD” list.
- Extended SIG config mapping to include Ubuntu 24.04 EdgeZone definitions and introduced a dedicated AzureLinux EdgeZone SIG config map (gallery/RG constants + lookup integration).
- Updated unit tests in
sig_config_test.goto assert the new EdgeZone SIG config entries.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/agent/datamodel/types.go | Adds new EdgeZone distro constants and marks them as VHD-available. |
| pkg/agent/datamodel/sig_config.go | Adds EdgeZone SIG config mappings for Ubuntu 24.04 and AzureLinux V3, plus gallery/RG constants and distro classification list updates. |
| pkg/agent/bakerapi.go | Includes AzureLinux EdgeZone SIG configs in GetDistroSigImageConfig and findSIGImageConfig. |
| pkg/agent/datamodel/sig_config_test.go | Adds/updates assertions for the new EdgeZone SIG config entries. |
…-2404-azurelinux3-sig-config # Conflicts: # pkg/agent/datamodel/sig_config.go # pkg/agent/datamodel/types.go
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Registers new EdgeZone distro keys in AgentBaker so they resolve to real SIG images before RP starts returning them, avoiding a provisioning-time image-lookup failure (a release-ordering gap we have hit before, e.g. AzureLinux4).
Adds SIG image-config mappings for:
aks-ubuntu-edgezone-containerd-24.04(AKSUbuntuEdgeZoneContainerd2404)aks-ubuntu-edgezone-containerd-24.04-gen2(AKSUbuntuEdgeZoneContainerd2404Gen2)aks-azurelinux-v3-edgezone(AKSAzureLinuxV3EdgeZone)aks-azurelinux-v3-edgezone-gen2(AKSAzureLinuxV3EdgeZoneGen2)Changes:
pkg/agent/datamodel/types.go— new distro constants + added toAKSDistrosAvailableOnVHD.pkg/agent/datamodel/sig_config.go— Ubuntu 24.04 EdgeZone added toSigUbuntuEdgeZoneImageConfig; newSigAzureLinuxEdgeZoneImageConfigmap + gallery/RG consts (AKSAzureLinuxEdgeZone/AKS-AzureLinux-EdgeZone); registered the new distros in the containerd/gen2/2404/AzureLinux classification lists.pkg/agent/bakerapi.go— iterate the new AzureLinux EdgeZone map and add it tofindSIGImageConfig.pkg/agent/datamodel/sig_config_test.go— assertions for all six EdgeZone entries.Build +
go test ./pkg/agent/datamodel/...pass.Note
AzureLinux V3 EdgeZone images are assumed to publish to a dedicated gallery
AKSAzureLinuxEdgeZone/AKS-AzureLinux-EdgeZone(mirrors the Ubuntu EdgeZone pattern). Please confirm the images actually land there before merge.Which issue(s) this PR fixes:
Fixes #