Skip to content

test: add e2e validation for MANA accelerated networking#8832

Open
titilambert wants to merge 14 commits into
mainfrom
add-e2e-tests-for-mana
Open

test: add e2e validation for MANA accelerated networking#8832
titilambert wants to merge 14 commits into
mainfrom
add-e2e-tests-for-mana

Conversation

@titilambert

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Adds end-to-end tests validating that MANA (Microsoft Azure Network Adapter)
accelerated networking is properly configured on V6 VM series. The tests cover
Ubuntu 22.04, Ubuntu 24.04, and Azure Linux V3.

Validations added:

  • MANA PCI device (00ba) is exposed to the VM
  • MANA kernel driver (mana.ko) is loaded
  • Virtual Function (VF) interface is bonded to eth0
  • Network traffic actually flows through the VF path

Additionally, MANA validation is run conditionally in ValidateCommonLinux
on any VM where MANA hardware is detected (V5+ series).

Which issue(s) this PR fixes:

Fixes #

@titilambert

Copy link
Copy Markdown
Contributor Author

This change is part of the following stack:

Change managed by git-spice.

Copilot AI review requested due to automatic review settings July 3, 2026 19:26
@titilambert

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds end-to-end validation for MANA (Microsoft Azure Network Adapter) accelerated networking on newer VM series, expanding the e2e suite to assert both device/driver presence and datapath correctness on Ubuntu 22.04/24.04 and Azure Linux V3.

Changes:

  • Added VMSS helper to explicitly enable Accelerated Networking on the primary NIC for targeted MANA scenarios.
  • Introduced MANA validation helpers (PCI device, driver availability, VF bonding, VF traffic counters) and conditionally ran them from ValidateCommonLinux when MANA hardware is detected.
  • Added dedicated e2e scenarios for Ubuntu 22.04, Ubuntu 24.04, and Azure Linux V3 on a V6 SKU, plus a new Tags.MANA filter flag.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
e2e/vmss.go Adds a helper to enable Accelerated Networking on the VMSS primary NIC.
e2e/validators.go Implements MANA detection and validation steps (PCI/driver/VF bonding/traffic).
e2e/validation.go Conditionally runs MANA validation as part of common Linux validations when hardware is detected.
e2e/types.go Adds a MANA tag to scenario filtering.
e2e/scenario_test.go Adds three VM-series coverage scenarios validating MANA on V6 SKUs across OSes.

Comment thread e2e/validators.go Outdated
Comment thread e2e/validators.go Outdated
Comment thread e2e/validators.go Outdated
Comment thread e2e/vmss.go
Comment thread e2e/validators.go Outdated
Copilot AI review requested due to automatic review settings July 3, 2026 19:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Comment thread e2e/validators.go Outdated
Comment thread e2e/validators.go Outdated
Comment thread e2e/validators.go
Comment thread e2e/validators.go Outdated
Copilot AI review requested due to automatic review settings July 3, 2026 19:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Comment thread e2e/validators.go
Comment thread e2e/validators.go Outdated
Comment thread e2e/validators.go
Copilot AI review requested due to automatic review settings July 3, 2026 19:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Comment thread e2e/validators.go Outdated
Comment thread e2e/validators.go Outdated
Comment thread e2e/validators.go Outdated
Comment thread e2e/scenario_test.go
Comment thread e2e/scenario_test.go
Comment thread e2e/scenario_test.go
Copilot AI review requested due to automatic review settings July 3, 2026 19:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Comment thread e2e/validators.go Outdated
Comment thread e2e/validators.go Outdated
Comment thread e2e/validators.go Outdated
Comment thread e2e/validators.go Outdated
Copilot AI review requested due to automatic review settings July 3, 2026 20:02
@titilambert titilambert force-pushed the add-e2e-tests-for-mana branch from 81bb13d to 294a4f3 Compare July 3, 2026 20:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Comment thread e2e/validators.go
Comment thread e2e/validators.go Outdated
Comment thread e2e/validators.go Outdated
Copilot AI review requested due to automatic review settings July 3, 2026 20:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Comment thread e2e/scenario_test.go
Comment thread e2e/scenario_test.go
Comment thread e2e/scenario_test.go
Comment thread e2e/validators.go Outdated
Copilot AI review requested due to automatic review settings July 6, 2026 19:42
@titilambert titilambert force-pushed the add-e2e-tests-for-mana branch from e685e10 to 1e8d5e4 Compare July 6, 2026 19:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Comment thread e2e/validators.go
Comment thread e2e/validators.go Outdated
Copilot AI review requested due to automatic review settings July 7, 2026 15:20
@titilambert titilambert force-pushed the add-e2e-tests-for-mana branch from acc7ca8 to cc1fdc0 Compare July 7, 2026 15:20
titilambert and others added 14 commits July 7, 2026 16:04
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Thibault Cohen <thicohen@microsoft.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@titilambert titilambert force-pushed the add-e2e-tests-for-mana branch from 8a906bc to 68fcd3a Compare July 7, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants