Add ability to enable CDI in containerd. #6014
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
abenn135
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1,
timmy-wright,
zachary-bailey,
bravebeaver and
smith1511
as code owners
| @@ -2,6 +2,10 @@ version = 2 | |||
| oom_score = -999{{if getHasDataDir .KubeletConfig}} | |||
| root = "{{.KubeletConfig.GetContainerDataDir}}"{{- end}} | |||
| [plugins."io.containerd.grpc.v1.cri"] | |||
| {{- if and ( .GetGpuConfig ) ( .GpuConfig.GetRequiresCdi ) }} | |||
There was a problem hiding this comment.
@abenn135 aks-node-controller isn't currently being used, for this change to immediately take effect you'd want to edit the containerd config template here: https://github.com/Azure/AgentBaker/blob/master/pkg/agent/baker.go#L1392 which AgentBaker then uses o template this variable: https://github.com/Azure/AgentBaker/blob/master/parts/linux/cloud-init/artifacts/cse_cmd.sh#L157
There was a problem hiding this comment.
+1 to this. We need this change for GB 200s
|
I'd also recommend enabling it in an Agentbaker e2e |
added 2 commits
March 10, 2025 15:17
Needed to support NVIDIA's DRA plugin, which will be used in tandem with upcoming GPU hardware.
…pact CDI enablement directly.
abenn135
force-pushed
the
abenn135/gb200
branch
from
7ddbf38 to
1567d97
Compare
|
No changes to cached containers or packages on Windows VHDs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
This PR adds the ability to enable CDI in containerd. This is needed to support NVIDIA's DRA plugin, which will be used alongside upcoming hardware.
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: