Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: trigger windows vhd ev2 build pipeline #3551

Closed
wants to merge 1 commit into from
Closed

chore: trigger windows vhd ev2 build pipeline #3551

wants to merge 1 commit into from

Conversation

wanqingfu
Copy link
Contributor

What type of PR is this?
Automatically trigger the pipeline to build windows vhd ev2 artifacts.

/kind feature

What this PR does / why we need it:
Generate artifacts for windows VHD sig automatically.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:
Only merge after #3439

Release note:

none

@wanqingfu wanqingfu added windows VHD your change will be included in the following VHDs build labels Aug 21, 2023
@wanqingfu wanqingfu temporarily deployed to test August 21, 2023 07:41 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6035171623

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on wanqingfu/trigger-ev2 at 61.309%
Totals Coverage Status
Change from base Build 6028066367: 61.3%
Covered Lines: 2651
Relevant Lines: 4324
💛 - Coveralls

@wanqingfu wanqingfu temporarily deployed to test August 21, 2023 08:46 — with GitHub Actions Inactive
@wanqingfu wanqingfu marked this pull request as ready for review August 21, 2023 09:07
@wanqingfu wanqingfu temporarily deployed to test August 22, 2023 06:41 — with GitHub Actions Inactive
@wanqingfu wanqingfu force-pushed the wanqingfu/trigger-ev2 branch from 69af5a3 to a0224a5 Compare August 23, 2023 07:48
@wanqingfu wanqingfu temporarily deployed to test August 23, 2023 07:48 — with GitHub Actions Inactive
@wanqingfu wanqingfu temporarily deployed to test August 23, 2023 09:09 — with GitHub Actions Inactive
@wanqingfu wanqingfu temporarily deployed to test August 23, 2023 09:48 — with GitHub Actions Inactive
@wanqingfu wanqingfu temporarily deployed to test August 23, 2023 09:59 — with GitHub Actions Inactive
@wanqingfu wanqingfu temporarily deployed to test August 23, 2023 10:46 — with GitHub Actions Inactive
@wanqingfu wanqingfu temporarily deployed to test August 23, 2023 11:14 — with GitHub Actions Inactive
@wanqingfu wanqingfu temporarily deployed to test August 23, 2023 11:20 — with GitHub Actions Inactive
@wanqingfu wanqingfu temporarily deployed to test August 23, 2023 11:28 — with GitHub Actions Inactive
@wanqingfu wanqingfu temporarily deployed to test August 23, 2023 11:42 — with GitHub Actions Inactive
@wanqingfu wanqingfu temporarily deployed to test August 23, 2023 11:51 — with GitHub Actions Inactive
@wanqingfu wanqingfu temporarily deployed to test August 23, 2023 12:15 — with GitHub Actions Inactive
@wanqingfu wanqingfu force-pushed the wanqingfu/trigger-ev2 branch from 93b71d7 to 8994aba Compare August 24, 2023 03:07
@wanqingfu wanqingfu temporarily deployed to test August 24, 2023 03:07 — with GitHub Actions Inactive
@wanqingfu wanqingfu temporarily deployed to test August 24, 2023 04:22 — with GitHub Actions Inactive
@wanqingfu wanqingfu force-pushed the wanqingfu/trigger-ev2 branch from 3c30bfe to 02f2516 Compare August 28, 2023 07:21
@wanqingfu wanqingfu temporarily deployed to test August 28, 2023 07:21 — with GitHub Actions Inactive
@wanqingfu wanqingfu temporarily deployed to test August 28, 2023 07:25 — with GitHub Actions Inactive
@wanqingfu wanqingfu temporarily deployed to test August 28, 2023 07:33 — with GitHub Actions Inactive
@wanqingfu wanqingfu temporarily deployed to test August 28, 2023 07:34 — with GitHub Actions Inactive
@wanqingfu wanqingfu temporarily deployed to test August 28, 2023 08:06 — with GitHub Actions Inactive
@wanqingfu wanqingfu temporarily deployed to test August 28, 2023 08:28 — with GitHub Actions Inactive
@wanqingfu wanqingfu temporarily deployed to test August 28, 2023 09:05 — with GitHub Actions Inactive
@wanqingfu wanqingfu temporarily deployed to test August 28, 2023 09:13 — with GitHub Actions Inactive
@wanqingfu wanqingfu temporarily deployed to test August 28, 2023 09:36 — with GitHub Actions Inactive
@wanqingfu wanqingfu force-pushed the wanqingfu/trigger-ev2 branch from 93fd9de to 7716f76 Compare August 30, 2023 07:48
@wanqingfu wanqingfu temporarily deployed to test August 30, 2023 07:48 — with GitHub Actions Inactive
cameronmeissner
cameronmeissner reviewed Aug 30, 2023
View reviewed changes
.pipelines/.vsts-vhd-windows-automation.yaml
pipeline_id="322622"
echo "Build ID for the release is $BUILD_ID"
run_id=$(az pipelines run --id $pipeline_id --variables VHD_PIPELINE_RUN_ID=$BUILD_ID | jq -r '.id')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where are we specifying the source artifacts to run this off of? the naming is usually based on the name of those artifacts - wondering if something funky is going on with that specifically

Copy link
Contributor Author

@wanqingfu wanqingfu Aug 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://learn.microsoft.com/en-us/azure/devops/pipelines/release/artifacts?view=azure-devops#artifact-sources---azure-pipelines if you are referring to this, the source comes from artifact variable Build.BuildNumber

the release name format is $(Build.BuildNumber)-$(rev:r) so assuming$(Build.BuildNumber) was the funky thing. It's empty.

ev2_artifacts is the primary artifact for SIG release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw --artifact-metadata-list "ev2_artifacts=$RUN_ID" the RUN_ID is the id for Build EV2 artifacts not the VHD build id (VHD_PIPELINE_RUN_ID) if that's confusing. Techincally no "name" is passed directly, it should be deduced from id (either BUILD_ID or run_id)

@wanqingfu wanqingfu force-pushed the wanqingfu/trigger-ev2 branch from 5cd5d0f to 264f6ab Compare August 31, 2023 08:53
@wanqingfu wanqingfu temporarily deployed to test August 31, 2023 08:53 — with GitHub Actions Inactive
@wanqingfu wanqingfu force-pushed the wanqingfu/trigger-ev2 branch from 264f6ab to 78f6e7f Compare September 7, 2023 07:49
@wanqingfu wanqingfu temporarily deployed to test September 7, 2023 07:49 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronmeissner cameronmeissner cameronmeissner left review comments

@AbelHu AbelHu Awaiting requested review from AbelHu AbelHu is a code owner

@ShiqianTao ShiqianTao Awaiting requested review from ShiqianTao

@junjiezhang1997 junjiezhang1997 Awaiting requested review from junjiezhang1997 junjiezhang1997 is a code owner

Assignees
No one assigned
Labels
build VHD your change will be included in the following VHDs windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wanqingfu @coveralls @cameronmeissner @strawberryfg