Skip service principal enrichment for MIWI clusters

[kimorris27]

Which issue this PR addresses:

https://issues.redhat.com/browse/ARO-11680

What this PR does / why we need it:

This PR modifies cluster enrichment such that the service principal enricher is skipped for MIWI clusters. I didn't add any additional MIWI-specific enrichment because it's not necessary; unlike in the service principal case, MIWI identities/federated credentials can't be rotated without going through the RP.

Test plan for issue:

1. Ran az aro list against local dev RP and observed an error saying that the SP enricher failed
2. Made code changes and restarted dev RP
3. Ran az aro list again and observed the error was no longer present, meaning SP enrichment had been skipped

Is there any documentation that needs to be updated for this PR?

N/A

How do you know this will function as expected in production?

E2E

[kimorris27]

/azp run ci, e2e

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[kimorris27]

/azp run ci

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kimorris27]

/azp run ci

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kimorris27]

/azp run ci

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[tsatam]

Implementation looks good to me as-is, but I'm curious if we want to consider a simpler approach where we just make the service principal enricher exit early if the cluster is a MIWI cluster, and not have to worry about maintaining the list and number of enrichers differently for CSP vs MIWI clusters: https://github.com/Azure/ARO-RP/blob/master/pkg/util/clusterdata/service_principal.go

[kimorris27]

Implementation looks good to me as-is, but I'm curious if we want to consider a simpler approach where we just make the service principal enricher exit early if the cluster is a MIWI cluster, and not have to worry about maintaining the list and number of enrichers differently for CSP vs MIWI clusters: https://github.com/Azure/ARO-RP/blob/master/pkg/util/clusterdata/service_principal.go

I'll go ahead and merge it as-is. It's true that that implementation would be a bit simpler in some sense, but we'd find ourselves either 1) emitting metrics for an enricher we're not running or 2) adding the same special handling around metric emission that I already added.

[tsatam]

Implementation looks good to me as-is, but I'm curious if we want to consider a simpler approach where we just make the service principal enricher exit early if the cluster is a MIWI cluster, and not have to worry about maintaining the list and number of enrichers differently for CSP vs MIWI clusters: https://github.com/Azure/ARO-RP/blob/master/pkg/util/clusterdata/service_principal.go

I'll go ahead and merge it as-is. It's true that that implementation would be a bit simpler in some sense, but we'd find ourselves either 1) emitting metrics for an enricher we're not running or 2) adding the same special handling around metric emission that I already added.

true, good point. Happy to keep the current implementation as-is then.