[ARO-12459] Deduplicate our dependencies on go-jose to a single version #3969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons that use josev4
… sometimes the format strings are weird
hawkowl
added
size-small
hawkowl
requested review from
jewzaam,
bennerv,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain and
kimorris27
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
|
||
| // AssertErrorMessage asserts that err.Error() is equal to wantMsg. | ||
| func AssertErrorMessage(t *testing.T, err error, wantMsg string) { | ||
| func AssertErrorMessage(t *testing.T, err error, wantMsg string, opts ...assertOptions) { |
There was a problem hiding this comment.
Can we introduce unit tests for the function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-12459
What this PR does / why we need it:
Move to go-jose v4 instead of the gopkg.in version + go-jose v3.
Test plan for issue:
E2E, unit tests
Is there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
E2E