Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARO-3258: propagate errors of ARO PullSecret controller to ARO operator #3947

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lbossis
Copy link
Collaborator

@lbossis lbossis commented Nov 8, 2024

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-3258

What this PR does / why we need it:

It is needed to propagate errors of ARO PullSecret controller to ARO operator in order to see those errors at the Operator level and to see all the controller errors in one place.

Test plan for issue:

[x] Unit Test Cases
[x] Local Cluster Creation
[] CI
[] E2E

Are there unit tests

Yes, https://github.com/Azure/ARO-RP/blob/master/pkg/operator/controllers/pullsecret/pullsecret_controller_test.go

How do you know this will function as expected in production?

Running all unit tests locally and verifying tests output

Is there any documentation that needs to be updated for this PR?

N/A

@lbossis
Copy link
Collaborator Author

lbossis commented Nov 8, 2024

@microsoft-github-policy-service agree company="Red Hat"

Copy link
Collaborator

@cadenmarchese cadenmarchese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pass looks good, just a few suggestions. thanks!

@cadenmarchese cadenmarchese added the chainsaw Pull requests or issues owned by Team Chainsaw label Nov 11, 2024
fahlmant
fahlmant previously approved these changes Nov 12, 2024
Copy link
Collaborator

@fahlmant fahlmant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

slawande2
slawande2 previously approved these changes Nov 13, 2024
Copy link
Collaborator

@tsatam tsatam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few fixups and additions to our test cases, otherwise LGTM!

@lbossis lbossis dismissed stale reviews from slawande2 and fahlmant via f2991ab November 15, 2024 20:04
Copy link
Contributor

@kimorris27 kimorris27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the reconciler LGTM, but I agree with Tanmay about the additional case where we can set the controller's Degraded status. I also think we could use some more unit test coverage and went into more detail in an existing comment thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chainsaw Pull requests or issues owned by Team Chainsaw
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants