fix: Ensure dns disabled for networks #3866
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Podman creates the default bridge network with dns_enabled to false. Subsequent calls to podman network create then create bridge networks where dns_enabled is set to true causing containers on said network to make use of podman's dnsutil plugin. This results in latency issues for gateway connections. This change ensures that networks created use similar settings to that of the default bridge network which has no latency issues.
jaitaiwan
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam and
bitoku
as code owners
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please rebase pull request. |
|
@jaitaiwan Is this PR still valid? |
|
Still relevant. We'll need this going forward when we start moving towards aks deployments as this will help to simulate the environment if I remember correctly and without dns-disabled we'll continue to see the same issues we saw in a previous incident. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes a latency issue with outbound connections caused by the creation of dedicated podman networks.
What this PR does / why we need it:
Fix a regression in outbound connection latency.
Test plan for issue:
RP deploy
Full details
Podman creates the default bridge network with dns_enabled to false. Subsequent calls to podman network create then create bridge networks where dns_enabled is set to true causing containers on said network to make use of podman's dnsutil plugin. This results in latency issues for gateway connections.
This change ensures that networks created use similar settings to that of the default bridge network which has no latency issues.
Which issue this PR addresses:
Fixes
What this PR does / why we need it:
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?