Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Quick RP compile build target #3849

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SudoBrendan
Copy link
Collaborator

@SudoBrendan SudoBrendan commented Sep 18, 2024

Which issue this PR addresses:

Fixes feedback from team that ci-rp is too slow.

What this PR does / why we need it:

This idea makes a "quick build" target in the Makefile and an accompanying Dockerfile change to opt in to a fast build process that skips validation of the code and binaries. By default (plain ol' docker build {...}), you execute everything, including production validation like FIPS compliance. You can now choose speed over production readiness by using docker build --target=quick-build {...}.

Only useful in local dev for faster feedback loops.

NOTE: My only major concern with this idea is that if we don't put our validation in front of people every day, all the time (which in my opinion makes them care about it and how performant/correct/etc it is), it inevitably degrades over time. I think that mentality is how we got to where we are today with releases.

A minor concern I have about this - is that I don't see what it improves compared to make aro, it offers nearly zero additional guarantees compared to that target, so I'm not sure why someone would pick this (slower target) over that?

So let's talk about it. I think this is about as good as a build "without the extra stuff" can get - but is it useful?

Test plan for issue:

make quick-rp
make run-rp || make run-portal

Is there any documentation that needs to be updated for this PR?

How do you know this will function as expected in production?

@SudoBrendan
Copy link
Collaborator Author

cc @bitoku and @jaitaiwan

@github-actions github-actions bot added the needs-rebase branch needs a rebase label Sep 19, 2024
Copy link

Please rebase pull request.

@jaitaiwan
Copy link
Contributor

LGTM, just needs doco around making sure you've got a build of portal avail as well. Likely needs something similar for portal I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase branch needs a rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants