microsoft.operationalinsights/workspaces wrong API version #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR also includes "make vendor; make generate" |
|
Please rebase pull request. |
|
@Makdaam do we still need this after 4.7? is so lets fix this and merge |
|
Closing. Stale there were sdk/api version related fixes in the mean time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes #1313
What this PR does / why we need it:
In List Azure Resources geneva action if the customer has an microsoft.operationalinsights/workspaces resource in the cluster RG then the geneva action fails with an error saying the API version is wrong for this resource.
By setting the API version to a static value we fix the issue with this resource. Finding a version dynamically for unknown resource types is the next step.
Test plan for issue:
I'll create a dev cluster with the problematic resource inside the rg and try the list azure resources geneva action endpoint.
Is there any documentation that needs to be updated for this PR?
no