frontend: Do not handle panics when running "go test" #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarnes
requested review from
bennerv,
SudoBrendan,
mociarain,
venkateshsredhat,
Nanyte25,
kostola and
hbhushan3
as code owners
frzifus
approved these changes
Feb 15, 2025
This effectively disables MiddlewarePanic when running unit tests. Catching a panic can sometimes obscure the root cause of a test failure, especially when the panic is intermittent and happens during a CI pipeline run where there's no opportunity to debug. This has been observed at least once before in #833 and may be happening again according to #1163
mbarnes
force-pushed
the
let-unit-tests-panic
branch
from
ae0b23f to
0cab644
Compare
| } | ||
| }() | ||
| // Do not catch panics when running "go test". | ||
| if !testing.Testing() { |
There was a problem hiding this comment.
This will ensure only for non testing envs .
venkateshsredhat
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This effectively disables
MiddlewarePanicwhen running unit tests.Catching a panic can sometimes obscure the root cause of a test failure, especially when the panic is intermittent and happens during a CI pipeline run where there's no opportunity to debug.
This has been observed at least once before in PR #833 and may be happening again according to issue #1163.