-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Q2 FY25 Policy Refresh #957
Open
cae-pr-creator
wants to merge
16
commits into
main
Choose a base branch
from
patch-policy-library
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Policy 📝
Issues / PR's related to Policy
Type: Bug 🪲
Something isn't working
Type: Feature Request ➕
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This pull request includes several updates to policy assignments and documentation within the Azure Landing Zones (ALZ) Bicep repository. The changes primarily involve renaming variables and updating policy definition versions.
Documentation updates:
docs/wiki/AssigningPolicies.md
: Updated variable names for policy assignment examples to align with new naming conventions. [1] [2]docs/wiki/PolicyDeepDive.md
: Updated the policy definition ID in the Kusto query example.Policy assignment updates:
infra-as-code/bicep/modules/policy/assignments/lib/README.md
: Renamed module variablemodPolicyAssignmentDenyPublicIP
tomodPolAssiDenyPublicIP
.definitionVersion
field to specify the version of the policy definition being used. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]These changes ensure consistency in variable naming and keep the policy definitions up to date with the latest versions.
Related Issues/Work Items
Closes #952
Closes #959
Fixes AB#38989
This PR fixes/adds/changes/removes
Breaking Changes
Notice: Breaking Changes in Bicep Module Configuration
As part of the migration to user-defined types (UDTs) for properties within the
parVpnGatewayConfig
andparExpressRouteGatewayConfig
parameters, the following breaking changes have been introduced:1. Supported SKUs Limited to Availability Zones
The list of supported SKUs for VPN and ExpressRoute gateways now only includes those with availability zones. This change aligns with the consolidation and migration updates outlined in the official Azure documentation. For more details, refer to the Gateway SKU Consolidation and Migration Guide.
2. Property Name Alignment for
parVpnGatewayConfig
The
generation
property inparVpnGatewayConfig
has been renamed tovpnGatewayGeneration
to align with the schema property name already used forparExpressRouteGatewayConfig
.3. Case Sensitivity of
bgpSettings
The
bgpsettings
property is now case-sensitive and must be written asbgpSettings
.Subproperty Changes:
asn
andpeerweight
subproperties withinbgpSettings
now require integer values instead of strings, ensuring consistency with the resource schema.Please update your configurations accordingly to avoid deployment errors.
Testing Evidence
Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch