Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Change Bicep Linter to expect latest non-preview apiVersion #706

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pjlewisuk
Copy link
Contributor

@pjlewisuk pjlewisuk commented Aug 7, 2024

PR Summary

  • Updated Bicep Linter use-recent-api-versions configuration to expect the latest non-preview version of an API, to remove / reduce the number of warnings we get when deploying via Bicep, even when the API version we're using is the latest (but >730 days old), e.g.
/home/runner/work/AKS-Construction/AKS-Construction/bicep/keyvaultkey.bicep(3,40) : Warning use-recent-api-versions: Use more recent API version for 'Microsoft.KeyVault/vaults'. '2022-07-01' is 768 days old, should be no more than 730 days old, or the most recent. Acceptable versions: 2024-04-01-preview, 2023-07-01, 2023-02-01, 2022-11-01 [https://aka.ms/bicep/linter/use-recent-api-versions]

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

@pjlewisuk pjlewisuk self-assigned this Aug 12, 2024
Copy link
Contributor

PR smells stale, no activity for 30 days. Stale Label will be removed if the PR is updated, otherwise closed in a month.

@github-actions github-actions bot added the stale An issue that hasn't had a lot of love recently label Sep 11, 2024
@pjlewisuk pjlewisuk added Keep Open and removed stale An issue that hasn't had a lot of love recently labels Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant