Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated regions and VM SKUs available in Helper UI, and changed default SKU selections #705

Merged
merged 35 commits into from
Aug 9, 2024

Conversation

pjlewisuk
Copy link
Contributor

@pjlewisuk pjlewisuk commented Aug 7, 2024

PR Summary

  • Updated list of locations to include all current regions
  • Updated Kubernetes version to current default (1.29.7)
  • Updated skuFamilies to include more recent VM gens and remove older gens
  • Updated default SKU choices:
    • Default system node is now Standard_D4ds_v5
    • Default user node selected in GUI is also Standard_D4ds_v5
    • Cost optimised clusters use the latest gen burstable Standard_B4s_v2
    • High performance clusters use the Standard_D8ds_v5
  • All workflows updated to use current gen SKUs
  • Changed system and user node pool names to align more closely with portal defaults
  • Updated logic to check whether each VM SKU has enough temp storage/cache to use ephemeral storage instead of managed storage for OS
  • Changed default OS disk size to 128 GB (for both Windows and Linux) to match portal behaviour

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

List of regions:
image

List of VM SKUs:
image

- Updated region list to include all current regions
- Updated SKU families to include latest v5 and remove oldest v2
- Updated generate-vm-sku-list.sh logic to pick correct storage parameter for ephemeral storage
- Updated cost optimised clusters to use Standard_B4s_v2, and performance clusters to Standard_D8ds_v4
- Updated workflows to use current gen VM SKUs Standard_D4ds_v5
Updated workflow to use in-branch version of AksDeploy-Basic.parameters.json isntead of hosted version (which won't be up-to-date with any changes in current branch)
…en effect as this is pulled from the latest published release rather than in-branch
…s to fail until changes in this PR get published.
@pjlewisuk pjlewisuk requested a review from samaea August 8, 2024 15:44
@pjlewisuk
Copy link
Contributor Author

Over to you @samaea to review before merging :)

LMK if you want a quick call to run through the changes

bicep/main.bicep Outdated Show resolved Hide resolved
@pjlewisuk
Copy link
Contributor Author

pjlewisuk commented Aug 8, 2024

I think at least part of the problem with this change is that with the 2024-01-01 and 2024-01-02-preview versions of the managedClusters API, there was a change of behaviour with unknown fields. From Azure/AKS#4060:

All current AKS API versions silently ignore unknown fields. An unknown field is a field that is not part of the AKS API. Starting in AKS API version 2024-01-01 and 2024-01-02-preview this behavior is changing. Unknown fields in a request will result in the request being rejected with an error stating that we don't understand the unknown field. This change only impacts new API versions and will not impact you unless you update to use an API version 2024-01-01 or later. Existing API calls (via ARM templates or otherwise) will continue to function as-is.

I pushed a change to update the managedClusters API to use version 2024-01-01 back in April (PR-691), which could have impacted this, as the main error being reported during failed builds was that the natGatewayProfile parameter was not understood, or might have been in the wrong place in the file. Looking at history it looks like builds were already failing, so not sure if this change was the root cause or not.

I have also reverted the API version to 2023-11-01 (which on it's own didn't help) and have another PR lined up (PR-707) to update a number of API versions across the project.

…h for PRs

- Reverted AKS API version to 2024-01-01
@pjlewisuk pjlewisuk enabled auto-merge (squash) August 9, 2024 18:54
Copy link
Contributor

@samaea samaea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pjlewisuk pjlewisuk merged commit 55cebf0 into main Aug 9, 2024
54 checks passed
@pjlewisuk pjlewisuk deleted the paullewis-regions-skus branch August 9, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants