Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bicep linter warnings for Bicep 0.20.4 #647

Merged
merged 6 commits into from
Oct 25, 2023
Merged

Bicep linter warnings for Bicep 0.20.4 #647

merged 6 commits into from
Oct 25, 2023

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Aug 17, 2023 •
edited
Loading

PR Summary

Various API version bumps.

Closes #637

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

@Gordonby Gordonby added test-deploy-privateconfig A PR flag to make sure that the Private deployment is run before merge test-deploy-byoconfig A PR flag to make sure that the BYO-vnet deployment is run before merge labels Aug 17, 2023
@Gordonby Gordonby self-assigned this Aug 17, 2023
@Gordonby Gordonby linked an issue Aug 17, 2023 that may be closed by this pull request
Check bicep resource provider version & dependson syntax #637
Closed
@Gordonby Gordonby mentioned this pull request Aug 24, 2023
Open
@github-actions
Copy link
Contributor

PR smells stale, no activity for 30 days. Stale Label will be removed if the PR is updated, otherwise closed in a month.

@github-actions github-actions bot added the stale An issue that hasn't had a lot of love recently label Sep 17, 2023
@github-actions github-actions bot closed this Oct 17, 2023
@Gordonby Gordonby reopened this Oct 25, 2023
@Gordonby
Copy link
Collaborator Author

@pjlewisuk
image

@Gordonby Gordonby enabled auto-merge (squash) October 25, 2023 10:25
@Gordonby Gordonby temporarily deployed to csu October 25, 2023 10:53 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu October 25, 2023 12:57 — with GitHub Actions Inactive
@pjlewisuk pjlewisuk self-requested a review October 25, 2023 16:58
pjlewisuk
pjlewisuk previously approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@pjlewisuk pjlewisuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjlewisuk pjlewisuk temporarily deployed to csu October 25, 2023 17:09 — with GitHub Actions Inactive
pjlewisuk
pjlewisuk approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@pjlewisuk pjlewisuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gordonby Gordonby merged commit 8a30089 into main Oct 25, 2023
56 checks passed
@Gordonby Gordonby deleted the gb-bicepswitchup branch October 25, 2023 20:43
@pjlewisuk pjlewisuk temporarily deployed to csu October 25, 2023 21:07 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjlewisuk pjlewisuk pjlewisuk approved these changes

Assignees

@Gordonby Gordonby

Labels
stale An issue that hasn't had a lot of love recently test-deploy-byoconfig A PR flag to make sure that the BYO-vnet deployment is run before merge test-deploy-privateconfig A PR flag to make sure that the Private deployment is run before merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check bicep resource provider version & dependson syntax
2 participants
@Gordonby @pjlewisuk