Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter default outbound Networking options #619 #631

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

nellyk
Copy link
Member

@nellyk nellyk commented Aug 9, 2023

PR Summary

Alter default outbound networking options as per #619

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

@Gordonby
Copy link
Collaborator

The Playwright tests will need to be reverted to what they looked like a few months ago if we're reverting this default... That's why the build is failing.

@Gordonby
Copy link
Collaborator

@nellyk - I've reverted the Playwright test for you.
This should be ready to merge once one of the core team approves.

@Gordonby Gordonby enabled auto-merge (squash) August 18, 2023 08:14
@samaea samaea requested a review from pjlewisuk August 31, 2023 15:57
Copy link
Contributor

@pjlewisuk pjlewisuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the following configurations:

  • Non-Production:
    • Cluster with additional security controls - defaults to SLB
    • Private cluster with isolating network controls - defaults to firewall (UDR)
  • Production:
    • Cluster with additional security controls - defaults to SLB
    • Private cluster with isolating network controls - defaults to firewall (UDR)

All four configurations deployed correctly, and when I visually inspected the resource groups they had the correct resources for egress (load balancer vs firewall).

Had to revert to bicep 0.20.4 for testing due to #656 which has started happening since bicep 0.21.1.

Happy for this to be merged.

@Gordonby Gordonby merged commit ef95b74 into main Sep 18, 2023
7 of 8 checks passed
@Gordonby Gordonby deleted the feat/networking-options branch September 18, 2023 16:13
@pjlewisuk
Copy link
Contributor

@nellyk - I've reverted the Playwright test for you. This should be ready to merge once one of the core team approves.

Thanks Gordon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants