Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for enabling the Dapr extension #350

Merged
merged 3 commits into from
Aug 12, 2022
Merged

Add support for enabling the Dapr extension #350

merged 3 commits into from
Aug 12, 2022

Conversation

rzyns
Copy link
Contributor

@rzyns rzyns commented Aug 11, 2022

Signed-off-by: Janusz Dziurzynski [email protected]

PR Summary

This adds two checkboxes to the addons page: one for enabling the Dapr extension, and one for enabling HA mode (with the default HA settings). Partly addresses #304

CleanShot 2022-08-11 at 18 53 40

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

github-actions[bot]
github-actions bot reviewed Aug 11, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, one of the team will evaluate shortly.

@rzyns
Add "dapr" to cspell
cd54969 
Signed-off-by: Janusz Dziurzynski <[email protected]>
@Gordonby Gordonby added the enhancement New feature or request label Aug 12, 2022
Gordonby
Gordonby requested changes Aug 12, 2022
View reviewed changes
Copy link
Collaborator

@Gordonby Gordonby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR.
Really impressed how you got in there with the codebase conventions.
Thank you!
Just a few minor suggestions and we can merge this.

.github/workflows_dep/regressionparams/dapr.json Outdated Show resolved Hide resolved
bicep/main.bicep Show resolved Hide resolved
bicep/main.bicep Outdated Show resolved Hide resolved
bicep/main.bicep Outdated Show resolved Hide resolved
helper/src/components/deployTab.js Show resolved Hide resolved
@rzyns
Tweaks based on review feedback
2d815ea 
Signed-off-by: Janusz Dziurzynski <[email protected]>
@rzyns
Copy link
Contributor Author

rzyns commented Aug 12, 2022 •
edited
Loading

Updated, @Gordonby. I added @description() annotations, but the conversations don't show them because the original commented lines are unchanged. EDIT: same goes for the addons.daprAddonHA line indeployTab.js

@Gordonby
Copy link
Collaborator

A deployment looks good

image

@Gordonby
Copy link
Collaborator

I'm going to merge it @rzyns
But FYI, we're not going to cut a release for a couple of weeks until after the summer break.

@Gordonby Gordonby merged commit 296969f into Azure:main Aug 12, 2022
@Gordonby Gordonby mentioned this pull request Oct 14, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Gordonby Gordonby Gordonby approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rzyns @Gordonby