Skip to content

Data-block-fix #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Data-block-fix #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b9958c
fix: update .gitignore to include tfplan and remove default location …
chenjia902 Oct 2, 2025
24c4ec4
fix: update function app publish resource to use base64sha256 for tri…
chenjia902 Oct 2, 2025
e742df4
fix: update default Node.js version for function app to 20
chenjia902 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,5 @@ override.tf.json
terraform.rc

# Artifacts
*.zip
*.zip
tfplan
5 changes: 3 additions & 2 deletions modules/function-app/function-app.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ resource "azurerm_windows_function_app" "function_app" {
"WEBSITE_RUN_FROM_PACKAGE" = "1",
"FUNCTIONS_WORKER_RUNTIME" = "node",
"AzureWebJobsDisableHomepage" = "true",
"WEBSITE_NODE_DEFAULT_VERSION" = "~18",
"WEBSITE_NODE_DEFAULT_VERSION" = "~20",
"EventHubConnection__credential" = "managedidentity",
"EventHubConnection__fullyQualifiedNamespace" = format("%s.servicebus.windows.net", var.event_hub_namespace_name),
"DD_API_KEY" = var.datadog_api_key,
Expand Down Expand Up @@ -129,7 +129,8 @@ locals {
resource "null_resource" "function_app_publish" {
depends_on = [local.publish_code_command, azurerm_role_assignment.role_assignment_storage, azurerm_role_assignment.role_assignment_event_hub]
triggers = {
input_json = filemd5(data.archive_file.functions_zip.output_path)
# input_json = filemd5(data.archive_file.functions_zip.output_path)
publish_has = data.archive_file.functions_zip.output_base64sha256
publish_code_command = local.publish_code_command
allow_public_access_command = local.allow_public_access_command
deny_public_access_command = local.deny_public_access_command
Expand Down
1 change: 0 additions & 1 deletion variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ variable "subscription_id" {

variable "location" {
description = "The location/region where the resources will be created."
default = "West Europe"
type = string
}

Expand Down