Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rtt stats for incoming videos #238

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Fix rtt stats for incoming videos #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Project/src/MakeCall/CallCard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,10 @@ export default class CallCard extends React.Component {
}
this.state.allRemoteParticipantStreams.forEach(v => {
let renderer = v.streamRendererComponentRef.current;
renderer?.updateReceiveStats(stats[v.stream.id]);
const videoStats = stats[v.stream.id];
const transportId = videoStats?.transportId;
const transportStats = transportId && data?.transports?.length ? data.transports.find(item => item.id === transportId) : undefined;
renderer?.updateReceiveStats(videoStats, transportStats);
});
if (this.state.logMediaStats) {
if (data.video.send.length > 0) {
Expand Down
6 changes: 4 additions & 2 deletions Project/src/MakeCall/FunctionalStreamRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export const FunctionalStreamRenderer = forwardRef(({
const [isMuted, setIsMuted] = useState(!!remoteParticipant?.isMuted);
const [displayName, setDisplayName] = useState(remoteParticipant?.displayName?.trim() ?? '');
const [videoStats, setVideoStats] = useState();
const [transportStats, setTransportStats] = useState();

useEffect(() => {
initializeComponent();
Expand Down Expand Up @@ -125,10 +126,11 @@ export const FunctionalStreamRenderer = forwardRef(({
}

useImperativeHandle(ref, () => ({
updateReceiveStats(videoStatsReceived) {
updateReceiveStats(videoStatsReceived, transportStatsReceived) {
if (videoStatsReceived) {
if (videoStatsReceived !== videoStats && stream.isAvailable) {
setVideoStats(videoStatsReceived);
setTransportStats(transportStatsReceived);
}
}
},
Expand Down Expand Up @@ -166,7 +168,7 @@ export const FunctionalStreamRenderer = forwardRef(({
{
videoStats && showMediaStats &&
<h4 className="video-stats">
<VideoReceiveStats videoStats={videoStats} />
<VideoReceiveStats videoStats={videoStats} transportStats={transportStats} />
</h4>
}
</div>
Expand Down
9 changes: 5 additions & 4 deletions Project/src/MakeCall/StreamRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ export default class StreamRenderer extends React.Component {
this.state = {
isSpeaking: false,
displayName: this.remoteParticipant.displayName?.trim(),
videoStats: undefined
videoStats: undefined,
transportStats: undefined
};
this.call = props.call;
}
Expand Down Expand Up @@ -122,9 +123,9 @@ export default class StreamRenderer extends React.Component {
return this.renderer;
}

updateReceiveStats(videoStats) {
updateReceiveStats(videoStats, transportStats) {
if (this.state.videoStats !== videoStats) {
this.setState({ videoStats });
this.setState({ videoStats, transportStats });
}
}

Expand Down Expand Up @@ -172,7 +173,7 @@ export default class StreamRenderer extends React.Component {
{
this.state.videoStats &&
<h4 className="video-stats">
<VideoReceiveStats videoStats={this.state.videoStats} />
<VideoReceiveStats videoStats={this.state.videoStats} transportStats={this.state.transportStats} />
</h4>
}
</div>
Expand Down
2 changes: 1 addition & 1 deletion Project/src/MakeCall/VideoReceiveStats.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default class VideoReceiveStats extends React.Component {
</tr>
<tr>
<td>rtt:</td>
<td>{this.props.videoStats.pairRttInMs} ms</td>
<td>{this.props.transportStats?.rttInMs ?? ''} ms</td>
</tr>
<tr>
<td>packetsPerSecond:</td>
Expand Down
Loading