-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Lazy wasm pt4 #11491
Open
Thunkar
wants to merge
34
commits into
master
Choose a base branch
from
gj/lazy_wasm_pt4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Lazy wasm pt4 #11491
+3,184
−2,571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kages into gj/lazy_wasm_pt4
… gj/lazy_wasm_pt4
… gj/lazy_wasm_pt4
… gj/lazy_wasm_pt4
dbanks12
approved these changes
Jan 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AVM related stuff all looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully one of the final parts of this refactor. Handles all the hashing done through
bb.js
. This is a monster and I'm sorry, but if there's something we do it's hash stuff.There should not be any unhandled promises left by this PR, thanks to eslint and careful reviewing anywhere we could now have
somethingThatIsNowAPromise.toString()
.UX regressions introduced by this PR:
e2e_authwit.test.ts
Other considerations:
parseAsync
withzod
instead ofparse
, which is known to be slower. I don't think this is going to be a big issue, since it's only used when doing RPC calls, but would love some inputs CC/ @spalladino@trackSpan
decorator can now take an async function for its attributesPromise.all
could have potentially improved it.@aztec/foundation/crypto/sync
, so that@aztec/merkle-trees
wouldn't complain. Since the TS implementation of our merkle trees is likely going away, I didn't bother updating them.