Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reenable constrained config for roots #10605

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

TomAFrench
Copy link
Member

This PR replaces the oracle calls used to calculate the roots of unity with constants which can be written directly into the bytecode now that we're not passing it across the unconstrained boundary.

@TomAFrench
Copy link
Member Author

TomAFrench commented Dec 11, 2024

We're getting a "stack too deep" here as while we're indexing ROOTS at indices known at compile-time, we don't have function specialization so we won't push the offset into the brillig function and so it needs to store the full ROOTS array. I've rewritten this so that we can resolve all of the array accesses at compile-time.

@TomAFrench TomAFrench force-pushed the tf/replace-constrained-roots branch from 12a594b to 8236ec4 Compare December 11, 2024 11:16
Base automatically changed from tf/reduce-constrained-boundary-jumps to mw/blob-circuit-2 December 12, 2024 17:54
@TomAFrench TomAFrench force-pushed the tf/replace-constrained-roots branch from 5786375 to 34af98e Compare December 13, 2024 21:48
Base automatically changed from mw/blob-circuit-2 to master December 16, 2024 10:36
@TomAFrench TomAFrench force-pushed the tf/replace-constrained-roots branch from 1035cb9 to a6a939f Compare December 16, 2024 10:44
TomAFrench and others added 8 commits December 16, 2024 13:27
* master: (119 commits)
  chore(master): Release 0.68.0 (#10834)
  feat: enable profiling with local PXE in cli-wallet (#10736)
  chore: values for sepolia deployment (#10362)
  fix: vm_full_tests.yml (#10912)
  chore: disable bb-sanitizers.yml (#10901)
  chore: Check yarn version during bootstrap (#10910)
  fix(p2p): default peer score penalties (#10896)
  feat: Updated metrics (#10885)
  feat: Reduce bundle sizes, remove polyfills (#10877)
  chore: Replace bbup.dev link (#10908)
  chore(avm): extra column information in lookups (#10905)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  chore: disable flake in e2e_fees/private_payments (#10898)
  chore(ci): disable e2e_cheat_codes.test.ts (#10897)
  fix: increase default heartbeat (#10891)
  fix(p2p): less verbose error (#10886)
  refactor: `contact` --> `sender` in PXE API (#10861)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant