refactor: remove PublicExecutor #10028
Open
+643
−731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanks12
changed the title
dbanks12
commented
Nov 19, 2024
Comment on lines
+198
to
215
| // Mock the internal private function. Borrowed from https://stackoverflow.com/a/71033167 | ||
| const simulateInternal: jest.SpiedFunction< | ||
| ( | ||
| stateManager: AvmPersistableStateManager, | ||
| executionResult: any, | ||
| allocatedGas: Gas, | ||
| transactionFee: any, | ||
| fnName: any, | ||
| ) => Promise<AvmFinalizedCallResult> | ||
| > = jest.spyOn( | ||
| this.publicTxSimulator as unknown as { | ||
| simulateEnqueuedCallInternal: PublicTxSimulator['simulateEnqueuedCallInternal']; | ||
| }, | ||
| 'simulateEnqueuedCallInternal', | ||
| ); | ||
| if (executorMock) { | ||
| this.publicExecutor.simulate.mockImplementation(executorMock); | ||
| simulateInternal.mockImplementation(executorMock); | ||
| } |
There was a problem hiding this comment.
The function is private, so I found this way to mock it. Should I just make the function public because we need to mock this in the prover client (and also in PublicTxSimulator tests)?
dbanks12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publicTxSimulator.simulate(tx)so that we only need to maintain that interface for external use of the simulatorgasLefttoAvmContractCallResult, removes gasLeft as an extra param to functions that accept call result.AvmFinalizedCallResultwhich is just likeAvmContractCallResultbut is friendlier for use externally to the AVM. Uses standard Gas type, and usesSimulationErrortype forrevertReason.