Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
fcarreiro authored Jan 10, 2025
1 parent dcaa1a5 commit fbd5ddf
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion barretenberg/cpp/pil/vm2/execution.pil
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ last * (1 - last) = 0;
// sel ^ (¬sel' ^ ¬last) = 0 iff
// sel * (1 - sel') * (1 - last) = 0
#[TRACE_CONTINUITY_1]
sel * ((1 - sel') * (1 - last)) = 0;
sel * (1 - sel') * (1 - last) = 0;
// If the current row is not an execution row, then there are no more execution rows after that.
// (not enforced for the first row)
#[TRACE_CONTINUITY_2]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ void Execution::add(ContextInterface& context, MemoryAddress a_addr, MemoryAddre
alu.add(context, a_addr, b_addr, dst_addr);
}

// TODO: My dispatch system makes me ahve a uint8_t tag. Rethink.
// TODO: My dispatch system makes me have a uint8_t tag. Rethink.
void Execution::set(ContextInterface& context, MemoryAddress dst_addr, uint8_t tag, MemoryValue value)
{
context.get_memory().set(dst_addr, std::move(value), static_cast<MemoryTag>(tag));
Expand Down

0 comments on commit fbd5ddf

Please sign in to comment.