Merge pull request #133 from theia-ide/mp/win32-race

win: fix race condition when starting a watcher
Axosoft · Mar 25, 2021 · ead6035 · ead6035
2 parents a76415a + bf3cbaf
commit ead6035
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/includes/win32/Watcher.h b/includes/win32/Watcher.h
@@ -36,6 +36,7 @@ class Watcher
 
     std::atomic<bool> mRunning;
     SingleshotSemaphore mHasStartedSemaphore;
+    SingleshotSemaphore mIsRunningSemaphore;
     mutable std::mutex mErrorMutex;
     std::string mError;
 

diff --git a/src/win32/Watcher.cpp b/src/win32/Watcher.cpp
@@ -38,7 +38,7 @@ std::string Watcher::getUTF8Directory(std::wstring path) {
     // before returning it to the user
     stripNTPrefix(uft16DirectoryString);
   }
-  
+
   int utf8length = WideCharToMultiByte(
       CP_UTF8,
       0,
@@ -239,6 +239,7 @@ void Watcher::start() {
   mRunner = std::thread([this] {
     // mRunning is set to false in the d'tor
     mRunning = true;
+    mIsRunningSemaphore.signal();
     run();
   });
 
@@ -247,11 +248,16 @@ void Watcher::start() {
     return;
   }
 
+  if (!mIsRunningSemaphore.waitFor(std::chrono::seconds(10))) {
+    setError("Watcher is not started");
+    return;
+  }
+
   QueueUserAPC([](__in ULONG_PTR self) {
     auto watcher = reinterpret_cast<Watcher*>(self);
     watcher->pollDirectoryChanges();
     watcher->mHasStartedSemaphore.signal();
-  } , mRunner.native_handle(), (ULONG_PTR)this);
+  }, mRunner.native_handle(), (ULONG_PTR)this);
 
   if (!mHasStartedSemaphore.waitFor(std::chrono::seconds(10))) {
     setError("Watcher is not started");