Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace eslint/dprint with biome #396

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

steabert
Copy link
Member

@steabert steabert commented Feb 10, 2025

Removes eslint and adds biome, which is a much faster linter
that can handle TypeScript out of the box, and also does formatting.

NOTE:

  • dprint is gone (as biome does formatting by itself, and it covers our source code)
  • biome-ignore was added where it gave an error (mostly exhaustive dependencies) as I did not want to change any logic in this PR, but I've marked them with FIXME (they either need a proper reason, or a fix)
  • there is a single config file which tried to match the original format as close as possible, and I've only added the lint rules that actually affect correctness (no opinionated shenanigans about code style) with some exceptions that we also use to avoid too many inline ignores

WANTED:

  • some more testing using VS Code (It worked on my machine but I rarely use it so it's good if someone else can try it out that hasn't used biome before)

@steabert steabert requested a review from a team as a code owner February 10, 2025 15:56
@steabert steabert self-assigned this Feb 10, 2025
@steabert steabert changed the title Stevenv/biome chore: replace eslint/dprint with biome Feb 10, 2025
@steabert steabert force-pushed the stevenv/biome branch 2 times, most recently from 8b45cc9 to 692c6df Compare February 10, 2025 16:04
Removes eslint and adds biome, which is a much faster linter
that can handle TypeScript out of the box, and also does formatting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant