-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't merge: code review #39
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PLEASE DON'T MERGE THIS BRANCH
|
||
.read-the-docs { | ||
color: #888; | ||
} */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented css if not needed
// import Products from "./Pages/Product Page/Products"; | ||
|
||
// import Homepage from "./Pages/Homepage/Homepage"; | ||
// import Products from "./Pages/Product Page/Products"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comments if not needed
return ( | ||
<div className="App"> | ||
<Navbar_main /> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra space
const [user, setUser] = useState(""); | ||
const [otp, setOtp] = useState(""); | ||
const [error, setError] = useState(""); | ||
const [loading, setisLoading] = useState(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setIsLoading
{ | ||
size: "invisible", | ||
callback: (response) => { | ||
// onSignup(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comment if not needed
import { createContext } from 'react'; | ||
|
||
|
||
// import cartProducts from "../db.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unnecessary comments
{/* <Text py="15px" >Shipping Charge : ₹50</Text> */} | ||
{/* <Text pb="15px"> | ||
total M.R.P : {totalamount + shipingcharge} | ||
</Text> */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unnecessary comments
import { useContext } from "react"; | ||
import { CartContext } from "../context/CartContext"; | ||
|
||
const Items = ({ id, title, Quantity, price, img }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give a proper name to your components. It should be readable and determining what this component is about
import { useContext } from "react"; | ||
|
||
import { CartContext } from "../context/CartContext"; | ||
// import { addtoCart } from "../redux/cart.action"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unnecessary comments
// import { addtoCart } from "../redux/cart.action"; | ||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra space
PLEASE DON'T MERGE THIS BRANCH. THIS IS JUST TO REVIEW COMMENTS.