refactor: Comment out close tab

Signed-off-by: Jerrico Dela Cruz <[email protected]>
Avanade · Oct 28, 2024 · 5135a0e · 5135a0e
1 parent dc1be86
commit 5135a0e
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 8 deletions.
diff --git a/.github/workflows/docker-build-and-push.yml b/.github/workflows/docker-build-and-push.yml
@@ -23,9 +23,6 @@ jobs:
           login-server: ${{ secrets.CONTAINER_REGISTRY_SERVER }}
           username: ${{ secrets.CONTAINER_REGISTRY_SERVER_USERNAME }}
           password: ${{ secrets.CONTAINER_REGISTRY_SERVER_PASSWORD }}
-      - name: Get the version from Git tags
-        id: get_version
-        run: echo "VERSION=$(git describe --tags --always)-${{ github.sha }}" >> $GITHUB_ENV
       - run: |
-          docker build . -t ${{ secrets.CONTAINER_REGISTRY_SERVER }}/${{ vars.APPSERVICE_NAME }}:${{ env.VERSION }}
-          docker push ${{ secrets.CONTAINER_REGISTRY_SERVER }}/${{ vars.APPSERVICE_NAME }}:${{ env.VERSION }}
+          docker build . -t ${{ secrets.CONTAINER_REGISTRY_SERVER }}/${{ vars.APPSERVICE_NAME }}:${{ github.sha }} -t ${{ secrets.CONTAINER_REGISTRY_SERVER }}/${{ vars.APPSERVICE_NAME }}:latest
+          docker push ${{ secrets.CONTAINER_REGISTRY_SERVER }}/${{ vars.APPSERVICE_NAME }}
diff --git a/src/goapp/routes.go b/src/goapp/routes.go
@@ -17,7 +17,7 @@ import (
 )
 
 func setPageRoutes() {
-	httpRouter.NOTFOUND(m.Chain(rtPages.NotFoundHandler))
+	httpRouter.NOTFOUND(m.Chain(rtPages.NotFoundHandler, m.AzureAuth()))
 
 	httpRouter.GET("/", m.Chain(rtPages.HomeHandler, m.AzureAuth()))
 	httpRouter.GET("/error/ghlogin", m.Chain(rtPages.GHLoginRequire, m.AzureAuth()))

diff --git a/src/goapp/templates/authenticationfailed.html b/src/goapp/templates/authenticationfailed.html
@@ -2,5 +2,5 @@
     if (window.opener == null) window.location = "/";
 
     window.opener.postMessage('failed');
-    window.close();
+    // window.close();
 </script>
diff --git a/src/goapp/templates/authenticationsuccessful.html b/src/goapp/templates/authenticationsuccessful.html
@@ -2,5 +2,5 @@
     if (window.opener == null) window.location = "/";
 
     window.opener.postMessage('success');
-    window.close();
+    // window.close();
 </script>