Feature/template #40
Feature/template #40
Conversation
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
There was a problem hiding this comment.
Can we please move $\src\Templates to $\tools\CoreEx.Template where the project name is CoreEx.Template etc. as this will eventually be published as a NuGet package and should follow our CoreEx.* naming convention. This should be the same as NTangle for consistency. This way src is reserved for genuine runtime deployed packages only.
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
|
|
||
| resources: | ||
| pipelines: | ||
| - pipeline: 'D365-Employee' # Name of the pipeline resource |
There was a problem hiding this comment.
Should this be renamed as D365 is not relevant?
There was a problem hiding this comment.
pipelines are work in progress - all those references will be removed
| jobs: | ||
| - template: app-template.yml | ||
| parameters: | ||
| AzureSubscription: rg-priv-inte-dev-nte-na-01 |
There was a problem hiding this comment.
is name configurable? nte-na does not seem correct?
There was a problem hiding this comment.
that will be deleted
| }, | ||
| "sources": [ | ||
| { | ||
| // "modifiers": [ |
There was a problem hiding this comment.
Should commented out content be removed?
There was a problem hiding this comment.
I was thinking that template eventually will be more dynamic, but not this week. We can remove or keep it on todo
| @@ -0,0 +1,89 @@ | |||
| namespace Company.AppName.Api.Controllers; | |||
|
|
|||
| [Route("api/employees")] | |||
There was a problem hiding this comment.
Route contains api does this need to be amended like my.hr?
There was a problem hiding this comment.
I think function app adds /api but webapp doesn't
| # deployToSlotOrASE: true | ||
| resourceGroupName: '$(ResourceGroupName)' | ||
| #slotName: '$(DeploymentSlot)' | ||
| package: '$(Pipeline.Workspace)/D365-Apps/D365-Apps_Package/Nte.Int.D365.Apps.FunctionApps.zip' |
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
Signed-off-by: Piotr <[email protected]>
|
@chullybun can you check if template project has been added correctly? |
|
@karpikpl - i built the solution from this branch, deployed all packages locally, installed the Pulumi, infra, etc. testing I will get to probably next week - we have Adi looking into that. Was there anything else you wanted me to validate? |
|
I think that's it. I've added a checklist on top on what is still pending. |
|
If there's a risk of code going out of sync. maybe this can be merged and I can add other things as separate PRs? |
Template for starting with CoreEx
Things to complete: