-
Notifications
You must be signed in to change notification settings - Fork 259
Changing all reference links to new api-docs side #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added two remarks for things we need to clarify before merging it.
@@ -26,7 +26,7 @@ Use `InvokeAsync` when you need to wait for the result, and potentially want to | |||
Both of the above methods have a dispatcher priority parameter. You can use this with the `DispatcherPriority` enumeration to specify the queue priority that the given job should be given. | |||
|
|||
:::info | |||
For the possible values of the `DispatcherPriority` enumeration, see [here](http://reference.avaloniaui.net/api/Avalonia.Threading/DispatcherPriority/). | |||
For the possible values of the `DispatcherPriority` enumeration, see [here](https://api-docs.avaloniaui.net/docs/T_Avalonia_Threading_DispatcherPriority#fields). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically this is no longer an enum. Should we correct the text to something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it's a special type that is used as an enum. I think it's okay
@@ -127,7 +127,7 @@ The items display horizontally, and those too far to the right would be hidden i | |||
## More Information | |||
|
|||
:::info | |||
For the complete API documentation about this control, see [here](http://reference.avaloniaui.net/api/Avalonia.Controls/ItemsRepeater/). | |||
For the complete API documentation about this control, see [here](TODO). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should we deal with this? The ItemsRepeater is no longer maintained. I'd prefer to just delete this section and add a warning badge at the top. Source could be linked to new repo however.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's just remove this paragraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick check. Aside from the items repeater part, looks good.
There are some new APIs that should be referenced on the main docs too. But can be done at some point later
I hope there are not too many copy/pasta issues since this was quite a lot of links to change.
I also updated the translations, so there should be no more link to the old reference docs