Improve input behavior for Browser #18349
Merged
+24
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
approved these changes
Mar 1, 2025
There was a problem hiding this comment.
The only reason it didn't call preventDefault was due to multithreading support. Which requires all C# code executed from the JS to return a promise/task. And preventDefault must be called in the same scope, without returning from the event or switching to another task.
But this PR makes sense at least for single-threaded applications, where this promise will end immediately without waiting.
maxkatz6
added
bug
os-browser
backport-candidate-11.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Improve input behavior for Browser, By change so we only call on preventDefault if handled is false.
#18348