Adding SelectionMode to TabStrip #18109
Open
+87
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I add the same key behaviors as the ListBox? (e.g. Moving with Navigation-Keys or Control to select specific items) |
emmauss
requested review from
grokys and
maxkatz6
and removed request for
grokys
|
You can test this PR using the following package version. |
maxkatz6
reviewed
Feb 15, 2025
Comment on lines
+31
to
+32
| Assert.Equal(-1, target.SelectedIndex); | ||
| Assert.Same(null, target.SelectedItem); |
There was a problem hiding this comment.
Unfortunately, we can't change default behavior.
TabStrip.SelectionMode default should be changed to match old behavior, even if it's different from ListBox.
There was a problem hiding this comment.
Likely, you only need to revert SelectionModeProperty.OverrideDefaultValue<TabStrip>(SelectionMode.AlwaysSelected); line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This implements #17969. In essence, it exposes the
SelectionModeproperty to make the selection mode configurable and it disables the behavior that the first item is always selected. This mimics the behavior of theListBox.What is the current behavior?
First item is always selected and you can't change the SelectionMode.
What is the updated/expected behavior with this PR?
I updated the ControlCatalog to allow to "play" with the settings:
Checklist
Fixed issues
Implements #17969